epugh commented on code in PR #4818:
URL: https://github.com/apache/solr/pull/4818#discussion_r3870828835
##########
solr/webapp/src/test/org/apache/solr/webapp/AdminUiSchemaDesignerTest.java:
##########
@@ -25,11 +24,9 @@
* Happy-path test of the Schema Designer screen: create a new schema, paste a
sample document and
* let the designer analyze it.
*
- * <p>AwaitsFix: the designer backend transiently fails its own prep/analyze
calls ("version
- * mismatch, retry", "Error loading solr config") when driven at automation
speed, making this test
- * flaky even with retries.
+ * <p>The Analyze action remains disabled until creation of the mutable schema
has completed, so a
+ * fast user cannot race the prep and analyze requests.
*/
[email protected](bugUrl =
"https://issues.apache.org/jira/browse/SOLR-18347";)
Review Comment:
BTW, if there is a lot of flakiness in this test, I am getting closer to
migrating the Admin UI to using the generated V2 Javascript client, which I
think is more reliable. And honestly, I think i might have made some commits
that may even have broke the `schema-designer.js` now that I think of it (not
sure), so it may be okay to not worry about this page... It's on my list to
get to "done done'!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
