abumarjikar commented on PR #4783: URL: https://github.com/apache/solr/pull/4783#issuecomment-5582075641
Hey @serhiy-bzhezytskyy Thanks for picking this up and building on the earlier work! Overall the changes look solid. A couple of quick questions before approving: 1. Split Default Semantics: Do we foresee any risk or confusion for callers with the per-command split defaults (true for core creation vs. false for rebalancing commands), or are we satisfied this is the cleanest compromise between safety and performance? 2. Fallback Behavior Verification: Can we double-check or confirm through existing test coverage that setting `-Dsolr.cloud.waitForFinalState.enabled=false` cleanly disables the wait loop across all affected commands without side effects for clients expecting immediate returns? Looks great overall—excited to see this land! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
