serhiy-bzhezytskyy commented on PR #4783: URL: https://github.com/apache/solr/pull/4783#issuecomment-5584916601
1. ADDREPLICA breaks the "core creation vs rebalancing" reading -- it creates a core and stays at `false`. The criterion is whether the wait is bounded in time: CREATE/CREATESHARD/SPLITSHARD wait on replicas that start empty, the other five on a replica catching up on existing data. I tried true for all 8 first and reverted two in ffa5017d838 after `CloudHttp2SolrClientTest.testPerReplicaStateCollection` timed out. So yes to the compromise -- and the confusion you are asking about was in the description you read, which listed five commands as `true`. Fixed, along with the ref guide. 2. Yes -- the explicit-`false` case was the one missing, and is now covered end to end on ADDREPLICA. Still not covered is the escape hatch on a command defaulting `true`; the description says why, and why that also bounds the change for a client expecting an immediate return. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
