sigram commented on PR #4676: URL: https://github.com/apache/solr/pull/4676#issuecomment-5662771247
The null checks in these error paths are not expensive, I think we should add them. I kind of agree that too many low level unit tests may become a nuisance .. but the other tests here verify end-user expectations wrt. the returned error info so I think they are useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
