dsmiley commented on code in PR #2687:
URL: https://github.com/apache/solr/pull/2687#discussion_r4149900264
##########
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##########
@@ -49,14 +48,13 @@ public OtelTracerConfigurator() {
}
@Override
- public Tracer getTracer() {
- return TraceUtils.getGlobalTracer();
Review Comment:
I suppose I merely mean the changes resulted in not needing to refer to
GlobalOpenTelemetry (albeit indirectly). But it's been a while 🤪 A goal of
this PR is to do that initialization in a singular spot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
