dsmiley commented on code in PR #2687:
URL: https://github.com/apache/solr/pull/2687#discussion_r4168718797


##########
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##########
@@ -61,6 +61,21 @@ public class TraceUtils {
 
   public static final String TAG_DB_TYPE_SOLR = "solr";
 
+  /** Is the OpenTelemetry Java agent present? */
+  public static final boolean OTEL_AGENT_PRESENT;

Review Comment:
   You are right; moved.  In addition, I added a check on the 2 methods there 
that reference `GlobalOpenTelemetry` to ensure that our initialization has 
happened, thus catching an accidental too-early use of getTracer, perhaps in 
some hypothetical NodeConfig or ServletFilter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to