epugh commented on code in PR #5168:
URL: https://github.com/apache/solr/pull/5168#discussion_r4294340831
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/ConfigApi.java:
##########
@@ -70,6 +70,25 @@ ConfigZnodeVersionResponse getZnodeVersion(
@Parameter(description = "Expected request-params znode version")
int expectedParamsVersion);
+ @GET
+ @Path("/requestHandler")
+ @StoreApiParameters
Review Comment:
what does `@StoreApiParameters` mean?
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/ConfigApi.java:
##########
@@ -70,6 +70,25 @@ ConfigZnodeVersionResponse getZnodeVersion(
@Parameter(description = "Expected request-params znode version")
int expectedParamsVersion);
+ @GET
+ @Path("/requestHandler")
Review Comment:
doiuble check sheet, but I think this is now plural? "requestHandlers"????
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/ConfigApi.java:
##########
@@ -70,6 +70,25 @@ ConfigZnodeVersionResponse getZnodeVersion(
@Parameter(description = "Expected request-params znode version")
int expectedParamsVersion);
+ @GET
+ @Path("/requestHandler")
+ @StoreApiParameters
+ @Operation(
+ summary = "Fetch request handlers (including implicit handler)",
+ tags = {"config"})
+ ConfigInfoResponse getRequestHandler(
+ @QueryParam("componentName")
Review Comment:
i *think* this is now a path param as well....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
