jaykay12 commented on code in PR #5168:
URL: https://github.com/apache/solr/pull/5168#discussion_r4297284930
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/ConfigApi.java:
##########
@@ -70,6 +70,25 @@ ConfigZnodeVersionResponse getZnodeVersion(
@Parameter(description = "Expected request-params znode version")
int expectedParamsVersion);
+ @GET
+ @Path("/requestHandler")
+ @StoreApiParameters
+ @Operation(
+ summary = "Fetch request handlers (including implicit handler)",
+ tags = {"config"})
+ ConfigInfoResponse getRequestHandler(
+ @QueryParam("componentName")
Review Comment:
We can’t put the handler name in the path the way we do for
searchComponents/{name} / queryResponseWriters/{name}.
Request-handler names are paths themselves (/select, /update/json/docs,
/admin/ping, …). A @PathParam would be a single segment, so names with / break
routing (and encoding gets ugly).
So for request handlers we keep filtering via query param:
GET .../config/requestHandlers?componentName=/update/json/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
