dsmiley commented on code in PR #5178:
URL: https://github.com/apache/solr/pull/5178#discussion_r4304291834
##########
solr/core/src/test/org/apache/solr/handler/admin/api/GetConfigSolrCloudTest.java:
##########
@@ -77,6 +82,33 @@ public void testGetZnodeVersionFromCollection() throws
Exception {
assertTrue(response.znodeVersion.params >= -1);
}
+ /**
+ * Reproduces a bug where a v2 "/config" request proxied internally to the
node actually hosting
+ * the collection fails with "Cannot find API for the path", because Solr
forwards such requests
+ * using the short "/c/{collection}/..." alias, but {@code
Constants.INDEX_PATH_PREFIX}'s JAX-RS
+ * {@code @Path} regex only recognizes "cores" or "collections", not "c".
+ */
Review Comment:
But 'c' is there (now). My point is that this is over-explaining. It's
enough to simply say "test that a request will proxy" But the method name is
so long that it says that... so I think no javadoc is needed.
Q: is this proxy bug fix actually specific to config? (okay if you don't
know; just curious)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
