sigram commented on PR #5178:
URL: https://github.com/apache/solr/pull/5178#issuecomment-6249483230
Looks good to me. Claude Opus 5.5 has this to say:
Real but minor effects:
1. The alias covers every resource using the shared prefix, not just
`/config`. That is Select, GetSchema, UpdateSchema, Config and Tasks, and each
becomes reachable directly at `/api/c/{coll}/...`. I think that's the intended
behaviour, but the PR title only mentions `/config`, so it's worth saying in
the PR description and changelog.
2. The test class now starts a 2-node cluster for every test, which is
slightly slower. That's acceptable.
Nits:
- The comment `at solr/webapp/web/js/angular/services.js:266` still says
`(cores|collections)`.
Result: authorization, proxy dispatch and generated clients are unaffected,
and the `c` alias now applies to all five resources using the shared prefix.
Remaining items are minor: an incomplete comment, and the PR title understating
the scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
