linslee75 commented on PR #5194: URL: https://github.com/apache/solr/pull/5194#issuecomment-6340607838
> do these changes work regardless of v1 or V2 API path? We moved to using the v2 schema api recently )(i believne!) and I want to make sure they are picked up. That is a solr 10 only change.... v1 and v2 share SchemaManager.performOperations; only the tagged operationType differs. The v2 single-field endpoint tags upsert-field, so canApplyWithoutReload now resolves it against the round-start schema: absent → additive, present → replace → reload. upsert-dynamic-field / upsert-field-type are left alone — nothing produces them (bulk bodies cannot resolve upsert-* through Jackson polymorphic resolution), and if one ever arrives it falls back to a reload. Alternative shape if you prefer it: add OpType#isAdditive(op, schema) to the enum, with the upsert constants delegating to the add/replace they resolve to, so perform can reuse that resolution instead of repeating the branch. Happy to switch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
