jaykay12 commented on code in PR #5190: URL: https://github.com/apache/solr/pull/5190#discussion_r4353321413
########## solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc: ########## @@ -29,8 +29,8 @@ More examples of SolrCLI in use are available throughout this Guide, particularl ==== This page documents the `bin/solr` script as it behaves by default. -An experimental re-implementation of the command line interface, built on picocli, is also included in this release. -It is disabled by default, and the options it accepts differ in places from those documented here. +A re-implementation of the command line interface, built on picocli, is also included in this release. +It is enabled by default, and the options it accepts differ in places from those documented here. See xref:cli/index.adoc[] if you would like to try it. ==== Review Comment: > I wonder if perhpas most of the remainder of this adoc page can be deleted since it is manually maintained and largely redundant with the new man pages? There are some general sections near the bottom that could perhaps stay. imo, we should not do this cleanup now. This solr-control-script-reference.adoc ties back to commons-cli & till the time we are supporting commons-cli there is no harm in keeping it. when we remove commons-cli support, this ref guide also dies alongside it. we are explicitly asking users to report any behaviour diff if they observe with respect to this page over in the bottom of index.sdoc. ########## solr/solr-ref-guide/modules/deployment-guide/deployment-nav.adoc: ########## @@ -18,7 +18,7 @@ .Deployment Guide * xref:solr-control-script-reference.adoc[] -** xref:cli/index.adoc[Experimental picocli CLI] +** xref:cli/index.adoc[PicoCLI] Review Comment: done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
