janhoy commented on code in PR #5190: URL: https://github.com/apache/solr/pull/5190#discussion_r4354911083
########## solr/solr-ref-guide/modules/deployment-guide/pages/solr-control-script-reference.adoc: ########## @@ -29,8 +29,8 @@ More examples of SolrCLI in use are available throughout this Guide, particularl ==== This page documents the `bin/solr` script as it behaves by default. -An experimental re-implementation of the command line interface, built on picocli, is also included in this release. -It is disabled by default, and the options it accepts differ in places from those documented here. +A re-implementation of the command line interface, built on picocli, is also included in this release. +It is enabled by default, and the options it accepts differ in places from those documented here. See xref:cli/index.adoc[] if you would like to try it. ==== Review Comment: The wording "See xref:cli/index.adoc[] if you would like to try it" feels strange when this is now the actual default. So we should instead actively point people to the new CLI page as the reference docs for what is now the default CLI commands. IMO these two pages shuold be written as if picocli was our only choice, and mention commons-cli as a side-note and escape hatch if they run in to a bug. It's probably ok to keep some of the tool descriptions on the control-script-reference page, unless they contradict options or output from picocli. Perhaps we should add a heading saying that the below section describes the fallback commons-cli and may differ from what is now default? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
