nick-boss-tech commented on PR #5161: URL: https://github.com/apache/solr/pull/5161#issuecomment-6390346069
**One P2 finding:** Aliased DELETE misses the real collection’s legacy lock directories. With name=aliasA&followAliases=true, the delete command resolves and removes the actual collection, but the new cleanup still uses aliasA. Persistent lock directories under the real collection’s name therefore remain after an upgrade. [Affected code](https://github.com/apache/solr/blob/c935397fa19488058273dc4269842f0f70ae8ecd/solr/core/src/java/org/apache/solr/cloud/api/collections/DistributedCollectionConfigSetCommandRunner.java#L456-L457) The cleanup needs the resolved collection identity, captured before deletion can remove the alias. Add an aliased-delete case to the new integration test. Otherwise, the container creation, bounded retries, live-lock protection, and mirrored-lock behavior look sound. The existing reviewer’s loop request is addressed, and all four current-head workflows are green. AI-generated, static review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
