psalagnac commented on code in PR #5161:
URL: https://github.com/apache/solr/pull/5161#discussion_r4371115093
##########
solr/core/src/java/org/apache/solr/cloud/ZkDistributedLockFactory.java:
##########
@@ -55,19 +58,57 @@ protected DistributedLock doCreateLock(
}
}
+ private DistributedLock newLock(boolean isWriteLock, String lockPath, String
lockIdToMirror)
+ throws KeeperException, InterruptedException {
+ return isWriteLock
Review Comment:
Minor: I don't think that's necessary to extract this in a method. Up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
