nick-boss-tech commented on PR #5128: URL: https://github.com/apache/solr/pull/5128#issuecomment-6390579146
See the contributing guidelines, you need a ticket number at or near the top. **One P2 regression found.** Non-incremental core backups fail on a fresh S3 prefix. The patch makes createDirectory() a no-op, but CreateCoreBackup and SnapShooter still require that empty prefix to exist before writing. Previously, the directory marker satisfied those checks. [Changed behavior](https://github.com/apache/solr/blob/91500069e48cbdaec20d868cca04c1d042e2fda3/solr/modules/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java#L179-L185) Both remaining checks need to respect supportsEmptyDirectories(), while preserving local-filesystem validation. Add an S3Mock test using BACKUPCORE with incremental=false and a fresh prefix. The new integration tests cover incremental collection backups. The markerless restore approach otherwise looks coherent and addresses the earlier review requests. AI-generated, static review. Flaky test may be fixed with this ticket/PR: https://issues.apache.org/jira/browse/SOLR-18506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
