elangelo commented on PR #5128: URL: https://github.com/apache/solr/pull/5128#issuecomment-6409935272
Thanks for the review, good catch. Confirmed: with `incremental=false`, `BACKUPCORE` (and the v2 core backup API, where that is the default) failed on a fresh S3 prefix with "Directory to contain snapshots doesn't exist", because both `CreateCoreBackup` and `SnapShooter.validateCreateSnapshot()` required the location to exist. Fixed in <commit>: both checks now only reject a missing location when `repository.supportsEmptyDirectories()` is true, so the local filesystem keeps its validation. `exists()` is still called first, so an unreachable bucket still fails up front. This also lets the ReplicationHandler `command=backup` write to a new S3 prefix. Added `S3IncrementalBackupTest.testNonIncrementalCoreBackupToLocationThatDoesNotExistYet`: it runs `BACKUPCORE` with `incremental=false` to a fresh prefix, checks the snapshot landed in S3, then runs `RESTORECORE` and verifies the doc count. It fails without the fix and passes with it. I have been applying for a JIRA account for quite a while now but all my requests seem to end in `/dev/null`.... hence no ticket :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
