nick-boss-tech commented on PR #5124: URL: https://github.com/apache/solr/pull/5124#issuecomment-6390984537
**One P2 finding:** The new replica-identity check happens before unload() acquires the core-operation lock. While the queued task waits, cleanup can remove the old core and another CREATE can reuse its name. The delayed unload then acts on the replacement, including deleting its files. See [ZkController.java:2982–2986](https://github.com/apache/solr/blob/09cadc87d60a427902cccec4f1ffbca6e1852c88/solr/core/src/java/org/apache/solr/cloud/ZkController.java#L2982-L2986). Keep the asynchronous fix, but check identity under the same lock as the unload, with a controlled replacement-race test. AI-generated, static review. Happy to produce a diff you can use or to open a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
