sarkaramrit1993 commented on PR #5124: URL: https://github.com/apache/solr/pull/5124#issuecomment-6400821568
Good catch. The identity check runs before `unload()` waits for the core op, so if the core is removed and a new one with the same name gets the op first, the queued unload acts on the replacement. The window is narrow, since it needs core-name reuse right at the handoff, but the effect is deleting a live replica's files, so it's worth closing. Doing the check under the same op means a small `CoreContainer` change, e.g. an unload that only proceeds if the `coreNodeName` still matches. @HoustonPutman would you rather have that in this PR or as a follow-up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
