dsmiley commented on PR #5291: URL: https://github.com/apache/solr/pull/5291#issuecomment-6642020566
This is about freaking time to have this! In separate PRs I want to add 'withDefaults(SolrParams)` instance method to make it easier to chain. And an `isEmpty()` method. The part I'm unsure about in this PR is the null handling. Annoyingly, `Map.of(...)` can't handle a null, and yet there are some occasional spots where we pass null in our code. I thought the empty string would be a good substitute but I'm unsure... maybe we should just disallow -- treat as a non-existent pair maybe? I'm inclined to go that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
