dsmiley commented on PR #5291: URL: https://github.com/apache/solr/pull/5291#issuecomment-6668848535
@nick-boss-tech `ModifiableSolrParams.of(null)` -- single arg is invalid. `ofPairs(String...)` that is inconsistent with existing methods this takes inspiration from on `Map`. RE unmodifiable... I don't think we should go so far as protecting the array values; risk/verbosity-extra-ops isn't the right trade-off IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
