isaric opened a new pull request, #5365:
URL: https://github.com/apache/solr/pull/5365

   https://issues.apache.org/jira/browse/SOLR-18612
   
   # Description
   
   SIP-22 step 5, fourth slice (after #5311 SolrJ, #5326 core init args, #5336 
admin/backup responses). This one covers the search-side `solr/core` sites 
where a `NamedList` is built with keys that never repeat: 24 sites in 14 Java 
files, plus the one Admin UI screen that read one of them in the flat form.
   
   Independent of #5336 (no shared files except the upgrade-note page: both add 
a "Response Format" section with their own bullets, so whichever merges second 
gets a one-line merge of the bullet lists).
   
   # Solution
   
   Response-visible, each keyed by something unique (term, document key, field 
name, fixed names):
   
   - `LukeRequestHandler`: a field's `histogram` and `topTerms`
   - `MoreLikeThisHandler`: `interestingTerms` with 
`mlt.interestingTerms=details`
   - `MoreLikeThisComponent`: the SolrCloud `moreLikeThis` section, keyed by 
document, as single-node already was
   - `SearchHandler`: the `debug`/`explain` section emitted for an empty result
   - `ManagedResource` / `RestManager`: `initArgs` of managed resources
   - `IGainTermsQParserPlugin` (`featuredTerms`, `docFreq`), 
`TextLogisticRegressionQParserPlugin` (`logit`)
   - `DirectUpdateHandler2.split`: the Core Admin `SPLIT` response (`timing`, 
`failed`)
   
   Internal, never serialized as is: the spellchecker and JSON-facet config 
conversions (`SpellCheckComponent`, `FacetParser`), 
`SignificantTermsQParserPlugin`'s working maps, and the grouping shard-result 
serializers (`SearchGroupsResultTransformer`, `TopGroupsResultTransformer`), 
whose output travels between shards as javabin and is read back as a 
`NamedList` either way.
   
   Admin UI: the Schema Browser's term-info panel parsed Luke's `topTerms` and 
`histogram` by index as a flat `[name, value, ...]` array, so it rendered 
nothing once they became objects (this is what broke the Admin UI tests on an 
earlier, larger version of this change). `schema.js` now reads both forms 
through one helper. The upgrade note says so.
   
   AI disclosure: the site classification, the edits, the notes and this 
description were drafted with Claude Code and reviewed by me.
   
   # Tests
   
   No new Java tests: the shape change is the documented intent of this SIP 
step. Ran the suites covering every changed path: `LukeRequestHandlerTest`, 
`LukeRequestHandlerDistribTest`, `MoreLikeThisHandlerTest`, 
`MoreLikeThisComponentTest`, `DistributedMLTComponentTest`, 
`DebugComponentTest`, `DistributedDebugComponentTest`, 
`SpellCheckComponentTest`, `DistributedSpellCheckComponentTest`, 
`SignificantTermsQParserPluginTest`, `TestDistributedGrouping`, 
`SolrIndexSplitterTest`, `SplitByPrefixTest`, the `rest` package and 
`TestJsonFacets`: 175 tests, all pass. Plus `./gradlew check -x test`.
   
   Coverage gaps, stated plainly: `{!igain}` and `{!tlogit}` have no functional 
tests in `solr/core` (they are driven by the streaming `features`/`train` 
expressions). The Admin UI browser tests (`:solr:webapp:test 
-Ptests.selenium=true`) could not run on my machine because Selenium Manager 
does not support Linux ARM; the rewritten `schema.js` parser was checked under 
Node with both input forms and produces identical structures, and the "Admin UI 
Tests" workflow should be allowed to run on this PR.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [x] I have developed this patch against the `main` branch.
   - [x] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [x] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   - [x] I have added a [changelog 
entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my 
change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to