isaric commented on code in PR #5365:
URL: https://github.com/apache/solr/pull/5365#discussion_r4642492898
##########
solr/core/src/java/org/apache/solr/search/IGainTermsQParserPlugin.java:
##########
@@ -147,9 +148,9 @@ public void collect(int doc) throws IOException {
@Override
public void complete() throws IOException {
- NamedList<Double> analytics = new NamedList<>();
- NamedList<Integer> topFreq = new NamedList<>();
- NamedList<Integer> allFreq = new NamedList<>();
+ NamedList<Double> analytics = new SimpleOrderedMap<>();
+ NamedList<Integer> topFreq = new SimpleOrderedMap<>();
Review Comment:
Good catch, and a pre-existing bug: allFreq is never filled, so every
featured term gets a second, null entry. Left docFreq as a NamedList in this
slice (1d3c635); filed SOLR-18677 for the duplicate entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]