[
https://issues.apache.org/jira/browse/SPARK-17840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561655#comment-15561655
]
Sean Owen commented on SPARK-17840:
-----------------------------------
I personally would favor a brief link to the contributing wiki at the top of
the pull request template, like "Please review ... before opening a pull
request."
And adding it to the bottom of README.md seems low-cost. I'd support those.
> Add some pointers for wiki/CONTRIBUTING.md in README.md and some warnings in
> PULL_REQUEST_TEMPLATE
> --------------------------------------------------------------------------------------------------
>
> Key: SPARK-17840
> URL: https://issues.apache.org/jira/browse/SPARK-17840
> Project: Spark
> Issue Type: Documentation
> Components: Documentation
> Reporter: Hyukjin Kwon
> Priority: Trivial
>
> It seems it'd better to give best efforts for describing the guides for
> creating JIRAs and PRs as there are several discussions about this.
> Maybe,
> - We could add some pointers of {{CONTRIBUTING.md}} or wiki[1] in README.md
> - Adds an explicit warning in PULL_REQUEST_TEMPLATE[2], in particular, for
> some PRs trying to merge a branch to another branch, for example as below:
> {quote}
> Please double check if your pull request is from a branch to a branch. It is
> probably wrong if the pull request title is "Branch 2.0" or "Merge ..." or if
> your pull request includes many commit logs unrelated to your changes to
> propose.
> {quote}
> Please refer the mailing list[3].
> [1] https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark
> [2] https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE
> [3]
> http://mail-archives.apache.org/mod_mbox/spark-dev/201610.mbox/%3CCAMAsSdKYEvvU%2BPdZ0oFDsvwod6wRRavqRyYmjc7qYhEp7%2B_3eg%40mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
