[
https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608322#comment-15608322
]
Peng Meng commented on SPARK-18088:
-----------------------------------
I am neutral for changing the selectorType "KBest" to "numTopFeatures".
"KBest", "percentile", and “fpr” is the same as the selector name in sklearn.
Now, the selectorType and parameter pairs are:
kbest=>numTopFeatures, percentile=>percentile, fpr=>alpha
After the change:
numTopFeatures=>numTopFeatures, percentile=>percentile, fpr=>alpha
The sklearn pairs are:
kbest=>k, percentile=>percentile, fpr=>alpha
Change the parameter numTopFeatures to k maybe also an option.
Hi [~srowen], what's your idea about this change?
> ChiSqSelector FPR PR cleanups
> -----------------------------
>
> Key: SPARK-18088
> URL: https://issues.apache.org/jira/browse/SPARK-18088
> Project: Spark
> Issue Type: Improvement
> Components: ML
> Reporter: Joseph K. Bradley
> Assignee: Joseph K. Bradley
> Priority: Minor
>
> There are several cleanups I'd like to make as a follow-up to the PRs from
> [SPARK-17017]:
> * Rename selectorType values to match corresponding Params
> * Add Since tags where missing
> * a few minor cleanups
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
