[
https://issues.apache.org/jira/browse/SPARK-18088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15609141#comment-15609141
]
Joseph K. Bradley commented on SPARK-18088:
-------------------------------------------
I'd actually propose:
* Rename kbest -> numTopFeatures
* Rename alpha -> fpr
* Have the selectorType string exactly match the corresponding Param name.
That will help clarify the API.
I don't think "k" is better than "numTopFeatures." Matching sklearn is a good
goal, but "k" is such a generic name that I'd prefer we just stick with
"numTopFeatures" in this case.
I'll send a PR to give a sense of what I intended.
> ChiSqSelector FPR PR cleanups
> -----------------------------
>
> Key: SPARK-18088
> URL: https://issues.apache.org/jira/browse/SPARK-18088
> Project: Spark
> Issue Type: Improvement
> Components: ML
> Reporter: Joseph K. Bradley
> Assignee: Joseph K. Bradley
> Priority: Minor
>
> There are several cleanups I'd like to make as a follow-up to the PRs from
> [SPARK-17017]:
> * Rename selectorType values to match corresponding Params
> * Add Since tags where missing
> * a few minor cleanups
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
