[ https://issues.apache.org/jira/browse/SPARK-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293834#comment-14293834 ]
Sean Owen commented on SPARK-5428: ---------------------------------- I think you have a point there. At least, I don't think it would otherwise hurt anything. > Declare the 'assembly' module at the bottom of the <modules> element in the > parent POM > -------------------------------------------------------------------------------------- > > Key: SPARK-5428 > URL: https://issues.apache.org/jira/browse/SPARK-5428 > Project: Spark > Issue Type: Improvement > Components: Build, Deploy > Reporter: Christian Tzolov > Priority: Trivial > Labels: assembly, maven, pom > > For multiple-modules projects, Maven follows those execution order rules: > http://maven.apache.org/guides/mini/guide-multiple-modules.html > If no explicit dependencies are declared Maven will follow the order declared > in the <modules> element. > Because the 'assembly' module is responsible to aggregate build artifacts > from other modules/project it make sense to be run last in the execution > chain. > At the moment the 'assembly' stays before modules like 'examples' which makes > it impossible to generate DEP package that contains the examples jar. > IMHO the rule of thumb should be to keep the 'assembly' module as the last > element in the <modules> list. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org