[
https://issues.apache.org/jira/browse/SPARK-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298412#comment-14298412
]
Christian Tzolov commented on SPARK-5428:
-----------------------------------------
To verify this change i've tried to bundle also the spark-yarn-shuffle inside
the DEB package. It didn't work!
Although put at the end of the modules' list the assembly module is executed
before the Spark Yarn Shuffle project and therefore fails to bundle the
yarn-shuffle jar.
The only reliable and clean solution is to declare the required dependency in
the assembly's pom.
Having the assembly module at the end of the list will not guarantee that it is
executed last.
Unless there are some other suggestions i think we should close this issue
> Declare the 'assembly' module at the bottom of the <modules> element in the
> parent POM
> --------------------------------------------------------------------------------------
>
> Key: SPARK-5428
> URL: https://issues.apache.org/jira/browse/SPARK-5428
> Project: Spark
> Issue Type: Improvement
> Components: Build, Deploy
> Reporter: Christian Tzolov
> Priority: Trivial
> Labels: assembly, maven, pom
>
> For multiple-modules projects, Maven follows those execution order rules:
> http://maven.apache.org/guides/mini/guide-multiple-modules.html
> If no explicit dependencies are declared Maven will follow the order declared
> in the <modules> element.
> Because the 'assembly' module is responsible to aggregate build artifacts
> from other modules/project it make sense to be run last in the execution
> chain.
> At the moment the 'assembly' stays before modules like 'examples' which makes
> it impossible to generate DEP package that contains the examples jar.
> IMHO the 'assembly' needs to be kept at the bottom of the <modules> list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
