[
https://issues.apache.org/jira/browse/SPARK-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334168#comment-14334168
]
Brennon York commented on SPARK-5312:
-------------------------------------
I'm not so sure the sbt {{show compile:discoveredMainClasses}} call will give
the output we want in this case. For reference, from the documentation of that
call states that "sbt detects the classes with public, static main methods for
use by the run method" and, to replicate the grep/sed code, we'd need a sbt
call to gather *all* {{public}} classes and not just the {{public static main}}
classes. If the goal is merely to rework the grep/sed code I could see what I
can do, but I'm not sure its going to get much better. I checked the sbt doc's
for something resembling what we're looking for and it doesn't seem they have
that feature. Thoughts?
> Use sbt to detect new or changed public classes in PRs
> ------------------------------------------------------
>
> Key: SPARK-5312
> URL: https://issues.apache.org/jira/browse/SPARK-5312
> Project: Spark
> Issue Type: Improvement
> Components: Project Infra
> Reporter: Nicholas Chammas
> Priority: Minor
>
> We currently use an [unwieldy grep/sed
> contraption|https://github.com/apache/spark/blob/19556454881e05a6c2470d406d50f004b88088a2/dev/run-tests-jenkins#L152-L174]
> to detect new public classes in PRs.
> Apparently, sbt lets you get a list of public classes [much more
> directly|http://www.scala-sbt.org/0.13/docs/Howto-Inspect-the-Build.html] via
> {{show compile:discoveredMainClasses}}. We should use that instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
