[
https://issues.apache.org/jira/browse/SPARK-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335565#comment-14335565
]
Brennon York commented on SPARK-5312:
-------------------------------------
New thoughts... So I checked out the link which seems like it would def. do
what we want it to do, but at the cost of much more complexity (unless I'm
missing something). It looks like the easiest way to get the tool to work would
be to add a separate scala program that would need to be executed (in the
{{run-tests-jenkins}} script) producing the public classes. Pros? It should get
us exactly the classes we want, then we could {{diff}} that against the master
branch and be on our way. Cons? An entire other scala program (again, unless
I'm missing a way to integrate it) that would need to be maintained / managed.
Not sure how important this is given the amount of code added to maintain into
the project. Thoughts?
> Use sbt to detect new or changed public classes in PRs
> ------------------------------------------------------
>
> Key: SPARK-5312
> URL: https://issues.apache.org/jira/browse/SPARK-5312
> Project: Spark
> Issue Type: Improvement
> Components: Project Infra
> Reporter: Nicholas Chammas
> Priority: Minor
>
> We currently use an [unwieldy grep/sed
> contraption|https://github.com/apache/spark/blob/19556454881e05a6c2470d406d50f004b88088a2/dev/run-tests-jenkins#L152-L174]
> to detect new public classes in PRs.
> Apparently, sbt lets you get a list of public classes [much more
> directly|http://www.scala-sbt.org/0.13/docs/Howto-Inspect-the-Build.html] via
> {{show compile:discoveredMainClasses}}. We should use that instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
