[ 
https://issues.apache.org/jira/browse/SPARK-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703562#comment-14703562
 ] 

Joseph K. Bradley commented on SPARK-9963:
------------------------------------------

{quote}When you say replace predictNodeIndex with the Node.predictImpl, do you 
mean override the abstract method predictImpl for the first argument in 
predictNodeIndex?{quote}

Both of those method recursively trace down the tree, simulating prediction, in 
order to find the leaf node which would make the prediction for a given feature 
vector.  Now that we have predictImpl, I believe predictNodeIndex is no longer 
needed.  Callers could instead use predictImpl, and then get the node index 
from the resulting node.

> ML RandomForest cleanup: replace predictNodeIndex with predictImpl
> ------------------------------------------------------------------
>
>                 Key: SPARK-9963
>                 URL: https://issues.apache.org/jira/browse/SPARK-9963
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Joseph K. Bradley
>            Priority: Trivial
>              Labels: starter
>
> Replace ml.tree.impl.RandomForest.predictNodeIndex with Node.predictImpl.
> This should be straightforward, but please ping me if anything is unclear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to