[ 
https://issues.apache.org/jira/browse/SPARK-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703824#comment-14703824
 ] 

Luvsandondov Lkhamsuren commented on SPARK-9963:
------------------------------------------------

Thanks for the clarification! I see two possibilities, correct me if I'm wrong:
As of right now, we have binnedFeatures and splits when calling 
predictNodeIndex. 
1. predictImpl(feature: Vector) takes Vector feature therefore we can create a 
feature from binnedFeatures and splits, then call predictImpl on the node.

2. create a another method predictImpl(binnedFeatures: Array[Int], splits: 
Array[Array[Split]]) in Node class.

Did you have anything else in mind?

> ML RandomForest cleanup: replace predictNodeIndex with predictImpl
> ------------------------------------------------------------------
>
>                 Key: SPARK-9963
>                 URL: https://issues.apache.org/jira/browse/SPARK-9963
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>            Reporter: Joseph K. Bradley
>            Priority: Trivial
>              Labels: starter
>
> Replace ml.tree.impl.RandomForest.predictNodeIndex with Node.predictImpl.
> This should be straightforward, but please ping me if anything is unclear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to