[
https://issues.apache.org/struts/browse/STR-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40252
]
Frank W. Zammetti commented on STR-3006:
----------------------------------------
Interesting idea Paul... how to you envision it working? How would having a
new <html:attribute> tag allow me to specify onfocusin on am <html:select> tag?
Doesn't sound like a bad idea to me.
Michael, my belief is that there is insufficient interest by current committers
to do anything but *very* minor fixes to the tags. I believe this based on
what I've seen over the past 1-2 years, maybe more, with regard to suggested
enhancements. Every single one that I can recall, not just my own, was shot
down for one reason or another, and often that reason is the policy Niall
mentioned. To me, that policy can be rephrased as we're not interested in
fixing or enhancing the tags any more because that's the ultimate outcome.
I am in agreement with you that not doing anything other than critical bug
fixes to anything but the HTML tags makes sense... JSTL is more than capable of
taking their place. The HTML tags are a different story though, they shouldn't
be allowed to stagnate, and I believe that's the course that has been choosen,
again based on what I've seen.
I am quite sure this change wouldn't break anything... it's mearly another
attribute that can optionally be supplied on the tags. And I agree, this is
IE7's fault, not Struts... that doesn't mean though that knowingly allowing the
Struts tags to not address a concern regarding what is still the dominant
browser on the market makes sense. Especially in this one particular case
where the solution is as simple as allowing a new optional attribute and
nothing more, it seems to be downright illogical to not want to do it.
Let me give a concrete example here... I discovered this problem today based on
testing my current project on IE7... now, in some parts of the app we used
html:select, in other parts just plain select's (multiple developers
unfortunately not standardizing one way or another). So, we have some selects
in the app that work properly in IE7 (the plain selects) and some that don't
(the html:select versions). The only solution I can see right now is what
Niall proposes: create my own subclass. My contention is that's not the right
answer for something that I consider a bug, albeit one caused by the browser
being incorrect. Ultimately, any Struts developer trying to use the onFocus
event of an html:select in IE7 will have to face this... is it right to tell
them all to create their own version of the HTML tags? Why the heck are they
using a framework then?
I will indeed do a diff tonight... I only attached the full files because I did
not have the ability to create a diff where I was when I opened the ticket, but
I thought it important to get this opened sooner than later. Look for it here
in a little while, even though I hold very little hope of anything being done
with it, at least no one will be able to say I didn't supply the bits.
> Struts HTML taglib's select element doesn't support proper onfocus events in
> IE7
> --------------------------------------------------------------------------------
>
> Key: STR-3006
> URL: https://issues.apache.org/struts/browse/STR-3006
> Project: Struts 1
> Issue Type: Bug
> Components: Taglibs
> Affects Versions: 1.0 Final, 1.0.1, 1.0.1 Final, 1.0.2, 1.1.1, 1.2.2,
> 1.2.4, 1.2.6 Beta, 1.2.7, 1.2.8, 1.2.9, 1.3.5, 1.3.6, 1.3.7, 1.4.0
> Environment: Any
> Reporter: Frank W. Zammetti
> Priority: Minor
> Attachments: BaseHandlerTag.java, struts-attr-tag.patch,
> struts-html.tld
>
>
> There is a known issue with IE7 and the plain <select> input element... let's
> say for example you have this:
> <html>
> <head>
> <title></title>
> </head>
> <body>
> <select onFocus="this.style.backgroundColor='#ff0000';">
> <option value="1">1</option>
> <option value="2">2</option>
> </select>
> </body>
> </html>
> In IE7, when you click on the dropdown arrow, the list of items will not
> immediately show up, you need to click it twice. This is due to the onFocus
> handler being attached. This is a known issue with IE. The solution is to
> simply add an onFocusIn handler which (usually) mimics the onFocus handler.
> However, in Struts 1, because the HTML taglib does not allow arbitrary
> attributes (something I believe it should, and I said as much on a BugZilla
> ticket which I can't seem to find in JIRA now, and along with it I suggested
> adding a strictHTML attribute, which would default to true, to allow (false)
> or disallow (true) arbitrary attributes), you cannot properly deal with this
> issue at present if you use the HTML taglib.
> Attached please find two updated files, BaseHandlerTag.java and
> struts-html.tld, which adds support for the onfocusin attribute.
> I marked this as Minor, but for those of us dealing with this issue right
> now, it's more like a Major :) I also consider it a bug since I don't see
> any viable work-around (someone can correct me if I'm wrong... and yes, not
> using the HTML taglib is I suppose a valid answer, but I'd be looking for
> something else)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
