[
https://issues.apache.org/jira/browse/WW-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717946#comment-13717946
]
bruce liu commented on WW-4146:
-------------------------------
I think, maybe the point is what parameter should put into cache .
in class com.opensymphony.xwork2.interceptor.ParametersInterceptor, method
"protected void setParameters(final Object action, ValueStack stack, final
Map<String, Object> parameters)", there is a loop like below :
[code]
for (Map.Entry<String, Object> entry : acceptableParameters.entrySet()) {
String name = entry.getKey();
Object value = entry.getValue();
try {
newStack.setParameter(name, value);
} catch (RuntimeException e) {
// some code do log here, i ignore it .
}
}
[/code]
when call "newStack.setParameter(name, value);" , it will call to
OnglUtil.compile() which will cache all parameter name .
here is my opinion: we should loop by properties in action , not parameteres
input by user .
properties in action class is fix, we can find out at request first time come
to the action and cache it for later request .
WDYT?
> cache attack at OgnlUtil.expressions
> -------------------------------------
>
> Key: WW-4146
> URL: https://issues.apache.org/jira/browse/WW-4146
> Project: Struts 2
> Issue Type: Bug
> Components: Expression Language
> Affects Versions: 2.3.15.1
> Reporter: bruce liu
> Fix For: 2.3.17
>
>
> in class com.opensymphony.xwork2.ognl.OgnlUtil, code :
> {code:java}
> tree = expressions.get(expression);
> if (tree == null) {
> tree = Ognl.parseExpression(expression);
> expressions.putIfAbsent(expression, tree);
> }
> {code}
> every parameter in the request cached in field expressions which is an
> instances of ConcurrentMap<String, Object>, use parameterName as key. so i
> construct huge different parameters that has different name (like "abc[123],
> abc[124]" ), they all cached in expressions, this cause outofmemory error,
> and let map acted like a list .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
