[
https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154713#comment-16154713
]
ASF GitHub Bot commented on WW-4849:
------------------------------------
GitHub user ThrawnCA opened a pull request:
https://github.com/apache/struts/pull/165
WW-4849 Restore ObjectFactory no-arg constructor for compatibility
As per [documentation](https://struts.apache.org/docs/objectfactory.html),
extending classes will expect to use the no-arg constructor. Removing it breaks
them all.
Moreover, since implementations are supposed to use no-arg constructors
themselves, how are they supposed to have immediate access to a Container to
pass to the superclass constructor?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ThrawnCA/struts
WW-4849-ObjectFactory-constructor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit f6028952077ae26ee3ceae463d2cb4e51049993d
Author: thrawnca <shell_layer-git...@yahoo.com.au>
Date: 2017-09-06T02:19:26Z
WW-4849 Restore ObjectFactory no-arguments constructor for compatibility
with extensions
----
> ObjectFactory constructor signature change breaks extensions
> ------------------------------------------------------------
>
> Key: WW-4849
> URL: https://issues.apache.org/jira/browse/WW-4849
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.5.13
> Reporter: Mitth'raw'nuruodo
>
> Commit {{6f91d0776a545c911ca4f2875ed9976614711ef9}} changed the signature of
> the {{ObjectFactory}} constructor, breaking all classes that extend
> {{ObjectFactory}} (as per https://struts.apache.org/docs/objectfactory.html).
> This affects eg the [{{guice-servlet}} Struts plugin|
> https://github.com/google/guice/blob/master/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java].
> This was not listed on the [2.5.13 version
> notes|https://struts.apache.org/docs/version-notes-2513.html] as a breaking
> change, and breaking changes should preferably be avoided in critical
> security updates.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
