[ https://issues.apache.org/jira/browse/WW-4849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155643#comment-16155643 ]
Aleksandr Mashchenko commented on WW-4849: ------------------------------------------ _to ensure that a container can only be injected once_ That is not the issue, take a look at https://issues.apache.org/jira/browse/WW-4827. Required objects should be injected in the constructor. The spring object factory does exactly that. The constructor injection along with the setter injection didn't play nice for me when I tried that. Have you tested it with some non default object factory e.g. spring? [~lukaszlenart] Could you add info about changes in object factory constructor to version notes. > ObjectFactory constructor signature change breaks extensions > ------------------------------------------------------------ > > Key: WW-4849 > URL: https://issues.apache.org/jira/browse/WW-4849 > Project: Struts 2 > Issue Type: Bug > Components: Core > Affects Versions: 2.5.13 > Reporter: Mitth'raw'nuruodo > Fix For: 2.5.14 > > > Commit {{6f91d0776a545c911ca4f2875ed9976614711ef9}} changed the signature of > the {{ObjectFactory}} constructor, breaking all classes that extend > {{ObjectFactory}} (as per https://struts.apache.org/docs/objectfactory.html). > This affects eg the [{{guice-servlet}} Struts plugin| > https://github.com/google/guice/blob/master/extensions/struts2/src/com/google/inject/struts2/Struts2Factory.java]. > This was not listed on the [2.5.13 version > notes|https://struts.apache.org/docs/version-notes-2513.html] as a breaking > change, and breaking changes should preferably be avoided in critical > security updates. -- This message was sent by Atlassian JIRA (v6.4.14#64029)