[
https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088970#comment-17088970
]
ASF GitHub Bot commented on WW-4789:
------------------------------------
lukaszlenart commented on issue #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-617345083
I think this PR is finally ready. I know it's huge so if there are
objections merging it AS-IS I can prepare another PR and just move
`ActionContext`s changes and then update the rest with another PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ActionContext should be immutable
> ---------------------------------
>
> Key: WW-4789
> URL: https://issues.apache.org/jira/browse/WW-4789
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 2.6
>
>
> Right now ActionContext is a bag of different contexts with mixed
> responsibility. Also some of them lay in ThreadLocal variable, but some are
> accessed directly. Also it is easily to modify the internal state which
> shouldn't be possible. The context should be constant during whole action
> execution period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
