[
https://issues.apache.org/jira/browse/WW-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089280#comment-17089280
]
ASF GitHub Bot commented on WW-4789:
------------------------------------
lukaszlenart commented on issue #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-617547853
Here are the
[ActionContext](https://github.com/apache/struts/pull/397/files#diff-8bd10f8c78a248734b503714a44e1dcc)
changes I'm talking about. All the rest is a consequence of those changes,
reviewing the changes should be sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ActionContext should be immutable
> ---------------------------------
>
> Key: WW-4789
> URL: https://issues.apache.org/jira/browse/WW-4789
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 2.6
>
>
> Right now ActionContext is a bag of different contexts with mixed
> responsibility. Also some of them lay in ThreadLocal variable, but some are
> accessed directly. Also it is easily to modify the internal state which
> shouldn't be possible. The context should be constant during whole action
> execution period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
