yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r593729482
##########
File path: core/src/test/java/org/apache/struts2/views/jsp/ui/HiddenTest.java
##########
@@ -62,6 +62,23 @@ public void testDisabled() throws Exception {
verify(TextFieldTag.class.getResource("Hidden-2.txt"));
}
+ public void testDynamicAttributes() throws Exception {
+ TestAction testAction = (TestAction) action;
+ testAction.setId(27357L);
+
+ HiddenTag tag = new HiddenTag();
+ tag.setPageContext(pageContext);
+ tag.setId("einszwei");
+ tag.setName("first");
+ tag.setValue("%{id}");
+ tag.setDynamicAttribute("", "data-wuffmiauww", "%{id}");
+
+ tag.doStartTag();
+ tag.doEndTag();
+
+ verify(TextFieldTag.class.getResource("Hidden-3.txt"));
Review comment:
:clap: maybe also `assertTrue(valueStack.pop()===testAction)` and then
`assertFalse(valueStack.pop()===tag)` to explicitly verify whole logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
