yasserzamani commented on a change in pull request #475:
URL: https://github.com/apache/struts/pull/475#discussion_r601457831



##########
File path: 
core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java
##########
@@ -121,6 +121,10 @@ public void renderTemplate(TemplateRenderingContext 
templateContext) throws Exce
         ActionInvocation ai = ActionContext.getContext().getActionInvocation();
 
         Object action = (ai == null) ? null : ai.getAction();
+        if (action == null) {
+            LOG.warn("Rendering tag {} out of Action scope, accessing directly 
JSPs is not recommended! " +
+                    "Please read 
https://struts.apache.org/security/#never-expose-jsp-files-directly";, 
templateName);

Review comment:
       :clap:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to