[ https://issues.apache.org/jira/browse/WW-5279?focusedWorklogId=842326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842326 ]
ASF GitHub Bot logged work on WW-5279: -------------------------------------- Author: ASF GitHub Bot Created on: 30/Jan/23 16:41 Start Date: 30/Jan/23 16:41 Worklog Time Spent: 10m Work Description: kusalk commented on code in PR #657: URL: https://github.com/apache/struts/pull/657#discussion_r1090875321 ########## core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java: ########## @@ -164,13 +174,10 @@ public boolean equals(Object o) { if (this == o) { return true; } - if (!(o instanceof XmlConfigurationProvider)) { return false; } - - final XmlConfigurationProvider xmlConfigurationProvider = (XmlConfigurationProvider) o; - + XmlConfigurationProvider xmlConfigurationProvider = (XmlConfigurationProvider) o; Review Comment: I find it clutters the code and goes against [present common practice](https://stackoverflow.com/questions/154314/when-should-one-use-final-for-method-parameters-and-local-variables) - but I can revert these changes if that is the preferred code style. Issue Time Tracking ------------------- Worklog Id: (was: 842326) Time Spent: 0.5h (was: 20m) > Improve readability of XmlConfigurationProvider class > ----------------------------------------------------- > > Key: WW-5279 > URL: https://issues.apache.org/jira/browse/WW-5279 > Project: Struts 2 > Issue Type: Task > Components: Core > Reporter: Kusal Kithul-Godage > Priority: Trivial > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)