[
https://issues.apache.org/jira/browse/WW-5279?focusedWorklogId=842561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842561
]
ASF GitHub Bot logged work on WW-5279:
--------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/23 12:20
Start Date: 31/Jan/23 12:20
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #657:
URL: https://github.com/apache/struts/pull/657#discussion_r1091847537
##########
core/src/main/java/com/opensymphony/xwork2/config/providers/XmlConfigurationProvider.java:
##########
@@ -164,13 +174,10 @@ public boolean equals(Object o) {
if (this == o) {
return true;
}
-
if (!(o instanceof XmlConfigurationProvider)) {
return false;
}
-
- final XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
-
+ XmlConfigurationProvider xmlConfigurationProvider =
(XmlConfigurationProvider) o;
Review Comment:
https://stackoverflow.com/questions/154314/when-should-one-use-final-for-method-parameters-and-local-variables/154510#154510
LGTM, but for this existing line "If I'm in someone else's code, I'm not going
to pull them out but if I'm writing new code I won't put them in." would fit.
With your explanation, both styles would be ok for me. Maybe @lukaszlenart
has some recommendation according to the Struts coding style?
Issue Time Tracking
-------------------
Worklog Id: (was: 842561)
Time Spent: 50m (was: 40m)
> Improve readability of XmlConfigurationProvider class
> -----------------------------------------------------
>
> Key: WW-5279
> URL: https://issues.apache.org/jira/browse/WW-5279
> Project: Struts 2
> Issue Type: Task
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Trivial
> Fix For: 6.2.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
