[ 
https://issues.apache.org/jira/browse/WW-5381?focusedWorklogId=897408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897408
 ]

ASF GitHub Bot logged work on WW-5381:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Dec/23 03:02
            Start Date: 29/Dec/23 03:02
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #824:
URL: https://github.com/apache/struts/pull/824#discussion_r1437960453


##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStackFactory.java:
##########
@@ -50,9 +50,11 @@ protected void setXWorkConverter(XWorkConverter converter) {
         this.xworkConverter = converter;
     }
 
-    @Inject(value = "com.opensymphony.xwork2.util.CompoundRoot")
-    protected void setClassResolver(ClassResolver classResolver) {
-        this.compoundRootAccessor = (RootAccessor) classResolver;
+    @Inject
+    protected void setCompoundRootAccessor(RootAccessor compoundRootAccessor) {
+        this.compoundRootAccessor = compoundRootAccessor;
+        OgnlRuntime.setPropertyAccessor(CompoundRoot.class, 
compoundRootAccessor);

Review Comment:
   Unified the previously 3 separate instances of CompoundRootAccessor





Issue Time Tracking
-------------------

    Worklog Id:     (was: 897408)
    Time Spent: 40m  (was: 0.5h)

> Introduce extension points for CompoundRootAccessor and MethodAccessor
> ----------------------------------------------------------------------
>
>                 Key: WW-5381
>                 URL: https://issues.apache.org/jira/browse/WW-5381
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Kusal Kithul-Godage
>            Priority: Minor
>             Fix For: 6.4.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to