[
https://issues.apache.org/jira/browse/WW-5381?focusedWorklogId=897411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897411
]
ASF GitHub Bot logged work on WW-5381:
--------------------------------------
Author: ASF GitHub Bot
Created on: 29/Dec/23 03:09
Start Date: 29/Dec/23 03:09
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #825:
URL: https://github.com/apache/struts/pull/825#discussion_r1437961845
##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStackFactory.java:
##########
@@ -87,12 +92,6 @@ protected void setContainer(Container container) throws
ClassNotFoundException {
OgnlRuntime.setPropertyAccessor(cls,
container.getInstance(PropertyAccessor.class, name));
}
- names = container.getInstanceNames(MethodAccessor.class);
Review Comment:
Now there is one drawback here - applications lose the ability to specify
custom method accessors for different types. They will now instead need to use
the extension point and do the delegation within this "global" method accessor.
I'm not sure there's a way to retain this capability and make it compatible
with the current extension point system.
Issue Time Tracking
-------------------
Worklog Id: (was: 897411)
Time Spent: 1h 10m (was: 1h)
> Introduce extension points for CompoundRootAccessor and MethodAccessor
> ----------------------------------------------------------------------
>
> Key: WW-5381
> URL: https://issues.apache.org/jira/browse/WW-5381
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
