[
https://issues.apache.org/jira/browse/WW-5391?focusedWorklogId=903236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903236
]
ASF GitHub Bot logged work on WW-5391:
--------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/24 06:27
Start Date: 02/Feb/24 06:27
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #867:
URL: https://github.com/apache/struts/pull/867#discussion_r1475594710
##########
plugins/osgi/src/main/java/org/apache/struts2/osgi/OsgiConfigurationProvider.java:
##########
@@ -255,16 +254,27 @@ public void setBundleAccessor(BundleAccessor acc) {
}
@Inject
- public void setVelocityManager(VelocityManager vm) {
- LOG.trace("OSGi ConfigurationProvider - setVelocityManager() called -
VelocityManager: [{}]", vm);
-
+ public void setVelocityManager(VelocityManagerInterface vmi) {
+ LOG.trace("OSGi ConfigurationProvider - setVelocityManager() called -
VelocityManager: [{}]", vmi);
+ if (!(vmi instanceof VelocityManager)) {
Review Comment:
Didn't bother with a marker interface here as this plugin is deprecated
anyway
Issue Time Tracking
-------------------
Worklog Id: (was: 903236)
Time Spent: 20m (was: 10m)
> Add interface for VelocityManager extension point
> -------------------------------------------------
>
> Key: WW-5391
> URL: https://issues.apache.org/jira/browse/WW-5391
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Velocity
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
