[ 
https://issues.apache.org/jira/browse/WW-5391?focusedWorklogId=903238&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-903238
 ]

ASF GitHub Bot logged work on WW-5391:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Feb/24 06:28
            Start Date: 02/Feb/24 06:28
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #867:
URL: https://github.com/apache/struts/pull/867#discussion_r1475595372


##########
plugins/velocity/src/main/java/org/apache/struts2/views/velocity/VelocityManagerInterface.java:
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.struts2.views.velocity;
+
+import com.opensymphony.xwork2.util.ValueStack;
+import org.apache.velocity.app.VelocityEngine;
+import org.apache.velocity.context.Context;
+
+import javax.servlet.ServletContext;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+/**
+ * @since 6.4.0
+ */
+public interface VelocityManagerInterface {

Review Comment:
   Maybe in 7.0 we can consider renaming `VelocityManager` to 
`StrutsVelocityManager` and `VelocityManagerInterface` to `VelocityManager`





Issue Time Tracking
-------------------

    Worklog Id:     (was: 903238)
    Time Spent: 40m  (was: 0.5h)

> Add interface for VelocityManager extension point
> -------------------------------------------------
>
>                 Key: WW-5391
>                 URL: https://issues.apache.org/jira/browse/WW-5391
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Velocity
>            Reporter: Kusal Kithul-Godage
>            Priority: Minor
>             Fix For: 6.4.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to