[ https://issues.apache.org/jira/browse/WW-5251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830982#comment-17830982 ]
Brian Andle edited comment on WW-5251 at 3/26/24 3:14 PM: ---------------------------------------------------------- [~lukaszlenart] : * Reviewed the PR. Looks good. I compared side by side each file. * Build branch locally, including tests. I've started building our application locally and now hitting various compile issues, in our code, from https://issues.apache.org/jira/browse/WW-5304 (and others) . Specifically, at the moment, core/src/main/java/com/opensymphony/xwork2/ActionContext.java dropped `getName()` which wasn't marked as deprecated. Looks like `org.apache.struts2.interceptor.NoParameters` was also removed. I'm still working though building our app, one fail at a time. Should these deprecations been dropped in minor releases as many were initially marked as deprecated in 6.0.0 with WW-4789 WW-3788 (and any others as I find them)? was (Author: JIRAUSER287474): [~lukaszlenart] : * Reviewed the PR. Looks good. I compared side by side each file. * Build branch locally, including tests. I've started building our application locally and now hitting various compile issues, in our code, from https://issues.apache.org/jira/browse/WW-5304 (and others) . Specifically, at the moment, core/src/main/java/com/opensymphony/xwork2/ActionContext.java dropped `getName()` which wasn't marked as deprecated. Looks like `org.apache.struts2.interceptor.NoParameters` was also removed. I'm still working though building out app, on fail at a time. Should these deprecations been dropped in minor releases as many were initially marked as deprecated in 6.0.0 with WW-4789 WW-3788 (and any others as I find them)? > Remove deprecated interfaces used with ServletConfigInterceptor > --------------------------------------------------------------- > > Key: WW-5251 > URL: https://issues.apache.org/jira/browse/WW-5251 > Project: Struts 2 > Issue Type: Improvement > Components: Core Interceptors > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 7.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > {{ServletConfigInterceptor}} supports a bunch of deprecated interfaces which > already have proper replacement and they should be removed > * {{org.apache.struts2.util.ServletContextAware}} > * {{org.apache.struts2.interceptor.ServletRequestAware}} > * {{org.apache.struts2.interceptor.ServletResponseAware}} > * {{org.apache.struts2.interceptor.ParameterAware}} > * {{org.apache.struts2.interceptor.SessionAware}} > * {{org.apache.struts2.interceptor.ApplicationAware}} > * {{org.apache.struts2.interceptor.PrincipalAware}} > all these interfaces have proper replacement in {{org.apache.struts2.action}} > package -- This message was sent by Atlassian Jira (v8.20.10#820010)