[ https://issues.apache.org/jira/browse/WW-5251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830982#comment-17830982 ]
Brian Andle edited comment on WW-5251 at 3/26/24 4:28 PM: ---------------------------------------------------------- [~lukaszlenart] : * Reviewed the PR. Looks good. I compared side by side each file. * Build branch locally, including tests. I've started building our application locally and now hitting various compile issues, in our code, from https://issues.apache.org/jira/browse/WW-5304 (and others) . Specifically, at the moment, core/src/main/java/com/opensymphony/xwork2/ActionContext.java dropped `getName()` which wasn't marked as deprecated. Looks like `org.apache.struts2.interceptor.NoParameters` was also removed. I'm still working though building our app, one fail at a time. Should these deprecations been dropped in minor releases as many were initially marked as deprecated in 6.0.0 with WW-4789 WW-3788 (and any others as I find them)? Update: I was able to get our app built, and started and light smoke test, and still maintain compatibility with our sister project (might not be the case with every Struts consumer though). Had to make the following additional adjustments to get from 6.1.2.2 to ~6.4.0.0/WW-5251 revert branch: * ActionContext.getContext().getName() _*->*_ ActionContext.getContext().getActionName() * org.apache.struts2.interceptor.NoParameters _*->*_ org.apache.struts2.action.NoParameters ** The `action` version does not exist in 6.1.2.2 * actionInvocation.getInvocationContext().setParameters(HttpParameters.create(parameters).build()); _*->*_ actionInvocation.getInvocationContext().withParameters(HttpParameters.create(parameters).build()); * Caffeine jar is now a required dependency was (Author: JIRAUSER287474): [~lukaszlenart] : * Reviewed the PR. Looks good. I compared side by side each file. * Build branch locally, including tests. I've started building our application locally and now hitting various compile issues, in our code, from https://issues.apache.org/jira/browse/WW-5304 (and others) . Specifically, at the moment, core/src/main/java/com/opensymphony/xwork2/ActionContext.java dropped `getName()` which wasn't marked as deprecated. Looks like `org.apache.struts2.interceptor.NoParameters` was also removed. I'm still working though building our app, one fail at a time. Should these deprecations been dropped in minor releases as many were initially marked as deprecated in 6.0.0 with WW-4789 WW-3788 (and any others as I find them)? Update: I was able to get our app built, and started and light smoke test, and still maintain compatibility with our sister project (might not be the case with every Struts consumer though). Had to make the following additional adjustments to get from 6.1.2.2 to ~6.4.0.0/WW-5251 revert branch: * ActionContext.getContext().getName() _*->*_ ActionContext.getContext().getActionName() * org.apache.struts2.interceptor.NoParameters _*->*_ org.apache.struts2.action.NoParameters * actionInvocation.getInvocationContext().setParameters(HttpParameters.create(parameters).build()); _*->*_ actionInvocation.getInvocationContext().withParameters(HttpParameters.create(parameters).build()); * Caffeine jar is now a required dependency > Remove deprecated interfaces used with ServletConfigInterceptor > --------------------------------------------------------------- > > Key: WW-5251 > URL: https://issues.apache.org/jira/browse/WW-5251 > Project: Struts 2 > Issue Type: Improvement > Components: Core Interceptors > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Major > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > {{ServletConfigInterceptor}} supports a bunch of deprecated interfaces which > already have proper replacement and they should be removed > * {{org.apache.struts2.util.ServletContextAware}} > * {{org.apache.struts2.interceptor.ServletRequestAware}} > * {{org.apache.struts2.interceptor.ServletResponseAware}} > * {{org.apache.struts2.interceptor.ParameterAware}} > * {{org.apache.struts2.interceptor.SessionAware}} > * {{org.apache.struts2.interceptor.ApplicationAware}} > * {{org.apache.struts2.interceptor.PrincipalAware}} > all these interfaces have proper replacement in {{org.apache.struts2.action}} > package -- This message was sent by Atlassian Jira (v8.20.10#820010)