[jira] [Work logged] (WW-5476) Mark tags attributes as deprecated

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5476?focusedWorklogId=940038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-940038
 ]

ASF GitHub Bot logged work on WW-5476:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Oct/24 06:35
            Start Date: 25/Oct/24 06:35
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #1096:
URL: https://github.com/apache/struts/pull/1096#issuecomment-2436994426

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1096) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [71.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1096&metric=new_coverage&view=list)
 (required ≥ 80%)  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [B Reliability Rating on New 
Code](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1096) 
(required ≥ A)  
     
   [See analysis details on 
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1096)
   
   ##   
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 '') Catch issues before they fail your Quality Gate with our IDE extension 
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 '') 
[SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 940038)
    Time Spent: 20m  (was: 10m)

> Mark tags attributes as deprecated
> ----------------------------------
>
>                 Key: WW-5476
>                 URL: https://issues.apache.org/jira/browse/WW-5476
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Tags
>            Reporter: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.7.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Tag's parameters can be confused with HttpParameters, but these are two 
> different things and shouldn't be mixed up due to security reasons.
> Using "attributes" instead of "parameters" can allow to distinguish these two 
> sets of data.
> Once introduced templates should use "attributes.${attrName}" instead of 
> "parameters.${paramName}", eg.:
> {code:java}
> <#if attributes.id??>
>  id="${attributes.id}"<#rt/>
> </#if> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)