[
https://issues.apache.org/jira/browse/WW-5476?focusedWorklogId=941329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-941329
]
ASF GitHub Bot logged work on WW-5476:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/24 09:06
Start Date: 01/Nov/24 09:06
Worklog Time Spent: 10m
Work Description: sonarcloud[bot] commented on PR #1105:
URL: https://github.com/apache/struts/pull/1105#issuecomment-2451554809
## [](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1105)
**Quality Gate passed**
Issues
 [1 New
issue](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1105&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted
issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1105&issueStatuses=ACCEPTED)
Measures
 [0 Security
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1105&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [50.0% Coverage on New
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1105&metric=new_coverage&view=list)
 [0.0% Duplication on New
Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1105&metric=new_duplicated_lines_density&view=list)
[See analysis details on
SonarCloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1105)
Issue Time Tracking
-------------------
Worklog Id: (was: 941329)
Time Spent: 1h (was: 50m)
> Mark tags attributes as deprecated
> ----------------------------------
>
> Key: WW-5476
> URL: https://issues.apache.org/jira/browse/WW-5476
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 6.7.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Tag's parameters can be confused with HttpParameters, but these are two
> different things and shouldn't be mixed up due to security reasons.
> Using "attributes" instead of "parameters" can allow to distinguish these two
> sets of data.
> Once introduced templates should use "attributes.${attrName}" instead of
> "parameters.${paramName}", eg.:
> {code:java}
> <#if attributes.id??>
> id="${attributes.id}"<#rt/>
> </#if> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
